Skip to content

[HOTFIX] [PROD] Post Release 2.4.1 - Protect billing account #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented May 6, 2020

Implementation for #529

Corresponding fix has been merged to DEV for testing #564.

This PR could be merged if we want to apply it as a hotfix, or it might be closed if we decide to go with a regular release.

@maxceem maxceem requested a review from vikasrohit May 6, 2020 07:47
@maxceem maxceem changed the title [HOTFIX] [PROD} Protect billing account [HOTFIX] [PROD] Protect billing account May 6, 2020
@vikasrohit
Copy link

@maxceem I would like to combine #560 #561 also in the same patch or full release. So, lets get them also in this branch for now and if we need to make a patch release, we can release them together.

@maxceem
Copy link
Contributor Author

maxceem commented May 6, 2020

ok @vikasrohit. I'm closing this PR and would raise a new one with all these fixes included.

@maxceem maxceem closed this May 6, 2020
@maxceem maxceem reopened this May 14, 2020
@maxceem
Copy link
Contributor Author

maxceem commented May 14, 2020

I'm reopening this PR as we decided not to include more functionality to the hotfix.

@maxceem maxceem changed the title [HOTFIX] [PROD] Protect billing account [HOTFIX] [DEV] Post Release 2.4.1 - Protect billing account May 14, 2020
@maxceem maxceem changed the title [HOTFIX] [DEV] Post Release 2.4.1 - Protect billing account [HOTFIX] [PROD] Post Release 2.4.1 - Protect billing account May 14, 2020
@vikasrohit
Copy link

@maxceem we can live with releasing it as regular release now. So, I guess we can keep the PR closed until it becomes urgent.

@maxceem
Copy link
Contributor Author

maxceem commented May 14, 2020

Ok, closing it.

@maxceem maxceem closed this May 14, 2020
@eisbilir eisbilir deleted the feature/protect-billing-account branch November 9, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants